hippogrief/pobsync
1
0
Fork 0
Code Issues 21 Pull Requests Actions Packages Projects Releases 3 Wiki Activity

(bugfix) Quote remote preflight shell commands #46

Merged
parkel merged 1 commits from issue-45-preflight-shell-quoting into master 2026-05-21 15:45:46 +02:00
Conversation 0 Commits 1 Files Changed 2 +10 -6
parkel commented 2026-05-21 15:45:42 +02:00
Owner
Copy Link

Summary

  • Quote remote preflight shell scripts as a single SSH argument.
  • Fix Remote rsync and Remote source root checks so SSH/remote shell handling no longer splits sh -lc incorrectly.
  • Add regression coverage for the generated preflight command shape.

Tests

  • docker compose run --rm web python manage.py test pobsync_backend -v 2
  • Result: 202 tests passed

Closes #45

## Summary - Quote remote preflight shell scripts as a single SSH argument. - Fix `Remote rsync` and `Remote source root` checks so SSH/remote shell handling no longer splits `sh -lc` incorrectly. - Add regression coverage for the generated preflight command shape. ## Tests - `docker compose run --rm web python manage.py test pobsync_backend -v 2` - Result: 202 tests passed Closes #45
parkel added 1 commit 2026-05-21 15:45:42 +02:00
(bugfix) Quote remote preflight shell commands 3fb8209aef 
Pass remote rsync and source-root preflight checks as a single quoted
shell command to SSH so the remote shell evaluates command -v and test
expressions reliably.

Refs #45
parkel merged commit 8633cbea26 into master 2026-05-21 15:45:46 +02:00
parkel deleted branch issue-45-preflight-shell-quoting 2026-05-21 15:45:46 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
area: future
Longer-term product direction.
 area: observability
Metrics, history, and capacity insights.
 area: policy
Backup policies, templates, and automation.
 area: restore
Restore and recovery workflows.
 area: security
Permissions, audit, and security hardening.
 bugfix
Bug fixes and correctness work.
 docs
Documentation and operator guidance.
 feature
New functionality.
 refactor
Internal restructuring without direct behavior changes.
 release
Release preparation and publishing.
 security
Security, permissions, and audit work.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
parkel
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: hippogrief/pobsync#46
Delete Branch "issue-45-preflight-shell-quoting"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?