hippogrief/pobsync
1
0
Fork 0
Code Issues 21 Pull Requests Actions Packages Projects Releases 3 Wiki Activity

Fix remote preflight shell quoting #45

New Issue
Closed
opened 2026-05-21 15:41:06 +02:00 by parkel · 0 comments
parkel commented 2026-05-21 15:41:06 +02:00
Owner
Copy Link

Problem

The connection preflight can report Remote source root as failed even when SSH and dry-run backups work. The remote checks currently pass sh, -lc, and the script as separate SSH arguments, which OpenSSH/remote shell handling can reinterpret incorrectly, especially for commands containing &&.

Scope

  • Quote remote shell scripts as a single command passed to SSH.
  • Cover source root and remote rsync preflight checks with tests.
  • Keep dry-run behavior unchanged.

Acceptance Criteria

  • Remote source root preflight builds a correctly quoted remote shell command.
  • Remote rsync preflight builds a correctly quoted remote shell command.
  • Existing preflight behavior and stored result shape remain compatible.
## Problem The connection preflight can report Remote source root as failed even when SSH and dry-run backups work. The remote checks currently pass sh, -lc, and the script as separate SSH arguments, which OpenSSH/remote shell handling can reinterpret incorrectly, especially for commands containing &&. ## Scope - Quote remote shell scripts as a single command passed to SSH. - Cover source root and remote rsync preflight checks with tests. - Keep dry-run behavior unchanged. ## Acceptance Criteria - Remote source root preflight builds a correctly quoted remote shell command. - Remote rsync preflight builds a correctly quoted remote shell command. - Existing preflight behavior and stored result shape remain compatible.
parkel added this to the 1.2 milestone 2026-05-21 15:41:06 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area: future
Longer-term product direction.
 area: observability
Metrics, history, and capacity insights.
 area: policy
Backup policies, templates, and automation.
 area: restore
Restore and recovery workflows.
 area: security
Permissions, audit, and security hardening.
 bugfix
Bug fixes and correctness work.
 docs
Documentation and operator guidance.
 feature
New functionality.
 refactor
Internal restructuring without direct behavior changes.
 release
Release preparation and publishing.
 security
Security, permissions, and audit work.
No Label
Milestone
No items
No Milestone 1.2
Projects
Clear projects
No project
Assignees
Clear assignees
parkel
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: hippogrief/pobsync#45
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?