hippogrief/pobsync
1
0
Fork 0
Code Issues 21 Pull Requests Actions Packages Projects Releases 3 Wiki Activity

(bugfix) Make snapshot pruning robust to archived permissions #66

Merged
parkel merged 1 commits from issue-47-65-robust-prune-cleanup into master 2026-05-28 20:59:24 +02:00
Conversation 0 Commits 1 Files Changed 2 +141 -7
parkel commented 2026-05-28 20:59:20 +02:00
Owner
Copy Link

Summary

  • Make retention prune and incomplete cleanup robust against restrictive directory modes preserved by rsync archive mode.
  • Add safe scheduled/manual snapshot delete path validation before permission repair or deletion.
  • Add tests for pruning and incomplete cleanup with non-traversable nested directories.

Tests

  • .venv/bin/python manage.py test src.pobsync_backend.tests.test_sql_retention --verbosity 2
  • .venv/bin/python manage.py check
  • git diff --check
  • .venv/bin/python manage.py test src.pobsync_backend --verbosity 2

Closes #65

## Summary - Make retention prune and incomplete cleanup robust against restrictive directory modes preserved by rsync archive mode. - Add safe scheduled/manual snapshot delete path validation before permission repair or deletion. - Add tests for pruning and incomplete cleanup with non-traversable nested directories. ## Tests - .venv/bin/python manage.py test src.pobsync_backend.tests.test_sql_retention --verbosity 2 - .venv/bin/python manage.py check - git diff --check - .venv/bin/python manage.py test src.pobsync_backend --verbosity 2 Closes #65
parkel added 1 commit 2026-05-28 20:59:20 +02:00
(bugfix) Make snapshot pruning robust to archived permissions 3893df4640 
Repair user permissions inside snapshot trees before deleting them so
retention prune and incomplete cleanup can remove directories copied with
restrictive rsync archive modes.

Add path validation for scheduled/manual snapshot deletes and cover
non-traversable nested directories in retention tests.
parkel merged commit fc6df89370 into master 2026-05-28 20:59:24 +02:00
parkel deleted branch issue-47-65-robust-prune-cleanup 2026-05-28 20:59:24 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
area: future
Longer-term product direction.
 area: observability
Metrics, history, and capacity insights.
 area: policy
Backup policies, templates, and automation.
 area: restore
Restore and recovery workflows.
 area: security
Permissions, audit, and security hardening.
 bugfix
Bug fixes and correctness work.
 docs
Documentation and operator guidance.
 feature
New functionality.
 refactor
Internal restructuring without direct behavior changes.
 release
Release preparation and publishing.
 security
Security, permissions, and audit work.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
parkel
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: hippogrief/pobsync#66
Delete Branch "issue-47-65-robust-prune-cleanup"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?