hippogrief/pobsync
1
0
Fork 0
Code Issues 21 Pull Requests Actions Packages Projects Releases 3 Wiki Activity

(feature) Require review before incomplete cleanup #67

Merged
parkel merged 1 commits from issue-47-reviewed-incomplete-cleanup into master 2026-05-28 21:08:22 +02:00
Conversation 0 Commits 1 Files Changed 5 +187 -44
parkel commented 2026-05-28 21:08:17 +02:00
Owner
Copy Link

Summary

  • Require incomplete snapshots to be reviewed before cleanup can delete them.
  • Show reviewed/needs review state in the retention plan and block cleanup until review is complete.
  • Keep cleanup confirmation counts scoped to reviewed incomplete snapshots.
  • Add tests for unreviewed blocking, reviewed cleanup availability, and service-level enforcement.

Tests

  • .venv/bin/python manage.py test src.pobsync_backend --verbosity 2
  • .venv/bin/python manage.py check
  • git diff --check

Closes #47

## Summary - Require incomplete snapshots to be reviewed before cleanup can delete them. - Show reviewed/needs review state in the retention plan and block cleanup until review is complete. - Keep cleanup confirmation counts scoped to reviewed incomplete snapshots. - Add tests for unreviewed blocking, reviewed cleanup availability, and service-level enforcement. ## Tests - .venv/bin/python manage.py test src.pobsync_backend --verbosity 2 - .venv/bin/python manage.py check - git diff --check Closes #47
parkel added 1 commit 2026-05-28 21:08:17 +02:00
(feature) Require review before incomplete cleanup b5e87abad2 
Require incomplete snapshots to be marked reviewed before the cleanup action
can delete them, and show review state in the retention plan UI.

Keep cleanup confirmation counts scoped to reviewed incomplete snapshots and
add coverage for blocked, reviewed, and deletion flows.
parkel merged commit 1f5c4e0756 into master 2026-05-28 21:08:22 +02:00
parkel deleted branch issue-47-reviewed-incomplete-cleanup 2026-05-28 21:08:22 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
area: future
Longer-term product direction.
 area: observability
Metrics, history, and capacity insights.
 area: policy
Backup policies, templates, and automation.
 area: restore
Restore and recovery workflows.
 area: security
Permissions, audit, and security hardening.
 bugfix
Bug fixes and correctness work.
 docs
Documentation and operator guidance.
 feature
New functionality.
 refactor
Internal restructuring without direct behavior changes.
 release
Release preparation and publishing.
 security
Security, permissions, and audit work.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
parkel
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: hippogrief/pobsync#67
Delete Branch "issue-47-reviewed-incomplete-cleanup"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?