Merge pull request '(bugfix) Allow blank notification webhook headers' (#96) from issue-95-notification-500 into master

Reviewed-on: #96

src/pobsync_backend/forms.py

@@ -208,6 +208,10 @@ class NotificationTargetForm(forms.ModelForm):
         recipients = [line.strip() for line in value.replace(",", "\n").splitlines() if line.strip()]
         return "\n".join(recipients)
 
+    def clean_webhook_headers(self) -> dict[str, object]:
+        value = self.cleaned_data.get("webhook_headers")
+        return value or {}
+
 
 class SshCredentialForm(forms.ModelForm):
     private_key_file = forms.FileField(

src/pobsync_backend/tests/test_views.py

@@ -318,6 +318,27 @@ class ViewTests(TestCase):
         self.assertEqual(target.channel, NotificationTarget.Channel.EMAIL)
         self.assertEqual(target.statuses, [BackupRun.Status.FAILED, BackupRun.Status.WARNING])
         self.assertEqual(target.email_to, "ops@example.test\nbackup@example.test")
+        self.assertEqual(target.webhook_headers, {})
+
+    def test_notification_target_form_allows_blank_webhook_headers(self) -> None:
+        self.client.force_login(self.staff_user)
+
+        response = self.client.post(
+            reverse("create_notification_target"),
+            {
+                "name": "ops",
+                "enabled": "on",
+                "channel": NotificationTarget.Channel.EMAIL,
+                "statuses": [BackupRun.Status.FAILED],
+                "email_to": "ops@example.test",
+                "webhook_headers": "",
+            },
+            follow=True,
+        )
+
+        self.assertRedirects(response, reverse("notification_targets"))
+        target = NotificationTarget.objects.get(name="ops")
+        self.assertEqual(target.webhook_headers, {})
 
     def test_notification_target_form_requires_channel_destination(self) -> None:
         self.client.force_login(self.staff_user)